feat: add encoding levels to RPC transport#144
Open
ashkalor wants to merge 3 commits intocloudflare:mainfrom
Open
feat: add encoding levels to RPC transport#144ashkalor wants to merge 3 commits intocloudflare:mainfrom
ashkalor wants to merge 3 commits intocloudflare:mainfrom
Conversation
|
…dundant JSON.stringify
7680e00 to
c8e4bdb
Compare
|
Having some examples in the README.md would be appreciated 🙏. |
Author
Hey just added them, let me know if it looks good. Didn't initially add them because I was expecting some kind of feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the encoding level architecture suggested by @kentonv in #133, handling serialization at the transport layer rather than through a global WireFormat hook.
Summary
EncodingLeveltype with four levels:stringify,devalue,partial,passthroughencodingLevelproperty toRpcTransportinterfacewrapTransport()helper for custom binary formats (CBOR, MessagePack, etc.)stringifyis the default)Encoding Levels
stringifydevaluepartialpassthroughMotivation
Binary formats like CBOR can significantly outperform JSON for large payloads by avoiding base64 encoding cycles. This architecture lets transports declare their capabilities and have serialization handled appropriately.